Closed Irallia closed 2 years ago
Merging #207 (c86937f) into master (fe3f74c) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #207 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 18 18
Lines 850 850
=======================================
Hits 836 836
Misses 14 14
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update fe3f74c...c86937f. Read the comment docs.
old values | new values |
---|---|
![]() |
![]() |
![]() |
![]() |
Looks good! How did you come up with the new values?
With exactly this PR. So far I have tested iGenvar only on one dataset regarding the parameters, now I have added others. And then I changed only one parameter at a time and saw how our result behaves. With some back and forth I have now ended up with the dafault values and plots created here. On the plots you can see that larger or smaller values would not give any improvement.
min_var_length = 30 (remains)
max_var_length = 10.000 (changed from 100.000)
max_tol_inserted_length = 50 (remains)
max_tol_deleted_length = 50 (remains)
max_overlap = 50 (changed from 10)
partition_max_distance = 50 (changed from 1.000)
hierarchical_clustering_cutoff = 0.3 (changed from 0.5)