seqan / iGenVar

The official repository for the iGenVar project.
BSD 3-Clause "New" or "Revised" License
9 stars 8 forks source link

[BENCHMARK] Run parameter benchmarks with different input data and update them. #207

Closed Irallia closed 2 years ago

Irallia commented 2 years ago

min_var_length = 30 (remains)

old value new value
min_var_length results all min_var_length results all
min_var_length results all min_var_length results all
min_var_length results all min_var_length results all
min_var_length results all min_var_length results all
min_var_length results all min_var_length results all

max_var_length = 10.000 (changed from 100.000)

old value new value
max_var_length results all max_var_length results all
max_var_length results all max_var_length results all
max_var_length results all max_var_length results all
max_var_length results all max_var_length results all
max_var_length results all max_var_length results all

max_tol_inserted_length = 50 (remains)

old value new value
max_tol_inserted_length results all max_tol_inserted_length results all
max_tol_inserted_length results all max_tol_inserted_length results all
max_tol_inserted_length results all max_tol_inserted_length results all
max_tol_inserted_length results all max_tol_inserted_length results all
max_tol_inserted_length results all max_tol_inserted_length results all

max_tol_deleted_length = 50 (remains)

old value new value
max_tol_deleted_length results all max_tol_deleted_length results all
max_tol_deleted_length results all max_tol_deleted_length results all
max_tol_deleted_length results all max_tol_deleted_length results all
max_tol_deleted_length results all max_tol_deleted_length results all
max_tol_deleted_length results all max_tol_deleted_length results all

max_overlap = 50 (changed from 10)

old value new value
max_overlap results all max_overlap results all
max_overlap results all max_overlap results all
max_overlap results all max_overlap results all
max_overlap results all max_overlap results all
max_overlap results all max_overlap results all

partition_max_distance = 50 (changed from 1.000)

old value new value
partition_max_distance results all partition_max_distance results all
partition_max_distance results all partition_max_distance results all
partition_max_distance results all partition_max_distance results all
partition_max_distance results all partition_max_distance results all
partition_max_distance results all partition_max_distance results all

hierarchical_clustering_cutoff = 0.3 (changed from 0.5)

old value new value
hierarchical_clustering_cutoff results all hierarchical_clustering_cutoff results all
hierarchical_clustering_cutoff results all hierarchical_clustering_cutoff results all
hierarchical_clustering_cutoff results all hierarchical_clustering_cutoff results all
hierarchical_clustering_cutoff results all hierarchical_clustering_cutoff results all
hierarchical_clustering_cutoff results all hierarchical_clustering_cutoff results all
codecov[bot] commented 2 years ago

Codecov Report

Merging #207 (c86937f) into master (fe3f74c) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #207   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files          18       18           
  Lines         850      850           
=======================================
  Hits          836      836           
  Misses         14       14           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fe3f74c...c86937f. Read the comment docs.

Irallia commented 2 years ago

iGenVar only - new Plots:

old values new values
iGenVar_only-results all iGenVar_only-results all
iGenVar_only-results DUP_as_INS all iGenVar_only-results DUP_as_INS all
Irallia commented 2 years ago

Looks good! How did you come up with the new values?

With exactly this PR. So far I have tested iGenvar only on one dataset regarding the parameters, now I have added others. And then I changed only one parameter at a time and saw how our result behaves. With some back and forth I have now ended up with the dafault values and plots created here. On the plots you can see that larger or smaller values would not give any improvement.