seqan / product_backlog

This repository is used as product backlog for all SeqAn relevant backlog items. This is intended to organise the work for the team.
2 stars 1 forks source link

Remove seqan3::detail::persist_view #416

Closed eseiler closed 2 years ago

eseiler commented 2 years ago

This is from the STL.

std::views::all can also bind rvalues via views::owning_range. Since views::zip and views::join_with use the new views::all_t to properly handle rvalues, I implemented the new behaviour.

A follow-up would be to get rid of seqan3::views::persist and use either seqan3::detail::owning_view or seqan3::detail::all{_t}. And also to add some documentation :D

_Originally posted by @eseiler in https://github.com/seqan/seqan3/pull/2971#discussion_r870416358_

https://github.com/seqan/seqan3/pull/2971/commits/31877fd6c2aedcc04e1d39dc6b09742ae0652982