std::views::all can also bind rvalues via views::owning_range.
Since views::zip and views::join_with use the new views::all_t to properly handle rvalues, I implemented the new behaviour.
A follow-up would be to get rid of seqan3::views::persist and use either seqan3::detail::owning_view or seqan3::detail::all{_t}.
And also to add some documentation :D
This is from the STL.
std::views::all
can also bind rvalues viaviews::owning_range
. Sinceviews::zip
andviews::join_with
use the newviews::all_t
to properly handle rvalues, I implemented the new behaviour.A follow-up would be to get rid of
seqan3::views::persist
and use eitherseqan3::detail::owning_view
orseqan3::detail::all{_t}
. And also to add some documentation :D_Originally posted by @eseiler in https://github.com/seqan/seqan3/pull/2971#discussion_r870416358_
https://github.com/seqan/seqan3/pull/2971/commits/31877fd6c2aedcc04e1d39dc6b09742ae0652982