search

seqan / seqan3

The modern C++ library for sequence analysis. Contains version 3 of the library and API docs.
https://www.seqan.de
Other
409 stars 82 forks source link

Add wchar_t to char_adaptation #231

Closed rrahn closed 6 years ago

rrahn commented 6 years ago

Currently our char_adaptation does not work with the type wchar_t, which is a distinct type.

rrahn commented 6 years ago

@mitra wchar_t must be guaranteed to be at least 32 bit large on unix systems and 16 bit on windows systems. This means, that the underlying integer type is supposed to be uint_least32_t for unix. Please add a TODO, that once Windows-support is enabled, we need to add a condition to use uint_least16_t instead. See here for a reference for the underlying integer type https://github.com/seqan/seqan3/blob/512bfd82d4f2e5dfb01b4a3bc59bd7476e772d60/include/seqan3/alphabet/adaptation/char.hpp#L74-L76

h-2 commented 6 years ago

implemented via #298