seqan / seqan3

The modern C++ library for sequence analysis. Contains version 3 of the library and API docs.
https://www.seqan.de
Other
405 stars 81 forks source link

[MISC] Add field::alignment deprecation to sam_file_output. #3087

Closed smehringer closed 1 year ago

smehringer commented 1 year ago

I forgot to add the static assert to the output file :see_no_evil:

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
seqan3 ✅ Ready (Inspect) Visit Preview Nov 7, 2022 at 9:22AM (UTC)
codecov[bot] commented 1 year ago

Codecov Report

Base: 98.22% // Head: 98.22% // No change to project coverage :thumbsup:

Coverage data is based on head (d034920) compared to base (8816830). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3087 +/- ## ======================================= Coverage 98.22% 98.22% ======================================= Files 275 275 Lines 12181 12181 ======================================= Hits 11965 11965 Misses 216 216 ``` | [Impacted Files](https://codecov.io/gh/seqan/seqan3/pull/3087?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=seqan) | Coverage Δ | | |---|---|---| | [include/seqan3/io/sam\_file/input.hpp](https://codecov.io/gh/seqan/seqan3/pull/3087/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=seqan#diff-aW5jbHVkZS9zZXFhbjMvaW8vc2FtX2ZpbGUvaW5wdXQuaHBw) | `100.00% <ø> (ø)` | | | [include/seqan3/io/sam\_file/output.hpp](https://codecov.io/gh/seqan/seqan3/pull/3087/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=seqan#diff-aW5jbHVkZS9zZXFhbjMvaW8vc2FtX2ZpbGUvb3V0cHV0LmhwcA==) | `100.00% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=seqan). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=seqan)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

smehringer commented 1 year ago

I can change both in this PR. Maybe was removed is more accurate?

eseiler commented 1 year ago

I can change both in this PR. Maybe was removed is more accurate?

The field::alignment was removed. Please see...?

It's more accurate :D