seqan / seqan3

The modern C++ library for sequence analysis. Contains version 3 of the library and API docs.
https://www.seqan.de
Other
409 stars 82 forks source link

[FIX] Redundant move #3095

Closed eseiler closed 1 year ago

eseiler commented 2 years ago

Occurs on gcc 13

See https://cdash.seqan.de/viewBuildError.php?buildid=11951

E.g.,

include/seqan3/io/views/detail/take_exactly_view.hpp:258:107: error: redundant move in return statement [-Werror=redundant-move]
  258 |     constexpr basic_iterator(base_base_t const & it) noexcept(noexcept(base_t{it})) : base_t{std::move(it)}
      |                                                                                                           ^
include/seqan3/io/views/detail/take_exactly_view.hpp:258:107: note: remove ‘std::move’ call
vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
seqan3 ✅ Ready (Inspect) Visit Preview Nov 5, 2022 at 7:12PM (UTC)
codecov[bot] commented 2 years ago

Codecov Report

Base: 98.22% // Head: 98.22% // No change to project coverage :thumbsup:

Coverage data is based on head (df496c8) compared to base (1bebb2c). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3095 +/- ## ======================================= Coverage 98.22% 98.22% ======================================= Files 275 275 Lines 12203 12203 ======================================= Hits 11987 11987 Misses 216 216 ``` | [Impacted Files](https://codecov.io/gh/seqan/seqan3/pull/3095?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=seqan) | Coverage Δ | | |---|---|---| | [include/seqan3/io/sam\_file/format\_bam.hpp](https://codecov.io/gh/seqan/seqan3/pull/3095/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=seqan#diff-aW5jbHVkZS9zZXFhbjMvaW8vc2FtX2ZpbGUvZm9ybWF0X2JhbS5ocHA=) | `95.00% <ø> (ø)` | | | [...clude/seqan3/io/views/detail/take\_exactly\_view.hpp](https://codecov.io/gh/seqan/seqan3/pull/3095/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=seqan#diff-aW5jbHVkZS9zZXFhbjMvaW8vdmlld3MvZGV0YWlsL3Rha2VfZXhhY3RseV92aWV3LmhwcA==) | `95.52% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=seqan). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=seqan)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.