seqan / seqan3

The modern C++ library for sequence analysis. Contains version 3 of the library and API docs.
https://www.seqan.de
Other
413 stars 82 forks source link

[FIX] Forward ref_ids to initialise_header_information() in constructors #3125

Closed tsnorri closed 1 year ago

tsnorri commented 1 year ago

– The passed value needs to be forwarded since it can be an rvalue reference.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
seqan3 ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 20, 2023 at 5:07PM (UTC)
tsnorri commented 1 year ago

Fixes #3124.

tsnorri commented 1 year ago

Edit: looks like the reason was that I had misread the type name.

Looks like fixing the issue was more difficult than I anticipated. Do you have any insight on why the headers do not match in sam/sam_file_write/0.no_records?

codecov[bot] commented 1 year ago

Codecov Report

Base: 98.18% // Head: 98.18% // No change to project coverage :thumbsup:

Coverage data is based on head (9566777) compared to base (404affb). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3125 +/- ## ======================================= Coverage 98.18% 98.18% ======================================= Files 276 276 Lines 12292 12292 ======================================= Hits 12069 12069 Misses 223 223 ``` | [Impacted Files](https://codecov.io/gh/seqan/seqan3/pull/3125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=seqan) | Coverage Δ | | |---|---|---| | [include/seqan3/io/sam\_file/output.hpp](https://codecov.io/gh/seqan/seqan3/pull/3125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=seqan#diff-aW5jbHVkZS9zZXFhbjMvaW8vc2FtX2ZpbGUvb3V0cHV0LmhwcA==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=seqan). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=seqan)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

eseiler commented 1 year ago

Thank you for the PR! I added a test and found another issue in initialise_header_information