Closed tsnorri closed 1 year ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated |
---|---|---|---|---|
seqan3 | ✅ Ready (Inspect) | Visit Preview | 💬 Add your feedback | Jan 20, 2023 at 5:07PM (UTC) |
Fixes #3124.
Edit: looks like the reason was that I had misread the type name.
Looks like fixing the issue was more difficult than I anticipated. Do you have any insight on why the headers do not match in sam/sam_file_write/0.no_records
?
Base: 98.18% // Head: 98.18% // No change to project coverage :thumbsup:
Coverage data is based on head (
9566777
) compared to base (404affb
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thank you for the PR!
I added a test and found another issue in initialise_header_information
– The passed value needs to be forwarded since it can be an rvalue reference.