seqan / seqan3

The modern C++ library for sequence analysis. Contains version 3 of the library and API docs.
https://www.seqan.de
Other
406 stars 81 forks source link

[FIX] deprecated const& version of benchmark::DoNotOptimize #3133

Closed eseiler closed 1 year ago

eseiler commented 1 year ago

Resolves #2747

Change: https://github.com/google/benchmark/commit/53df805dc820d720734d6538032f6b73f31f13ba Example of fix: https://github.com/google/benchmark/commit/f15f332fd1ae10ae6d13d816af9bcf3b196974cc

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
seqan3 ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 13, 2023 at 3:53PM (UTC)
codecov[bot] commented 1 year ago

Codecov Report

Base: 98.18% // Head: 98.18% // No change to project coverage :thumbsup:

Coverage data is based on head (95ae38f) compared to base (a719fb0). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3133 +/- ## ======================================= Coverage 98.18% 98.18% ======================================= Files 276 276 Lines 12292 12292 ======================================= Hits 12069 12069 Misses 223 223 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=seqan). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=seqan)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

eseiler commented 1 year ago

They explained it with

The compiler assume that a constant reference, even though escaped via asm
volatile, is unchanged.  The const-ref interface is deprecated to discourage
new uses of it, as subtle compiler optimizations (invariant hoisting, etc.) can
occur.