seqan / seqan3

The modern C++ library for sequence analysis. Contains version 3 of the library and API docs.
https://www.seqan.de
Other
412 stars 82 forks source link

[IO] Make seqan3::sam_file_header::program_info_t easier to copy #3145

Closed tsnorri closed 1 year ago

tsnorri commented 1 year ago

Fixes #3137.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
seqan3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2023 9:44am
codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (82c3fd8) 98.18% compared to head (1a07f35) 98.18%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3145 +/- ## ======================================= Coverage 98.18% 98.18% ======================================= Files 276 276 Lines 12292 12294 +2 ======================================= + Hits 12069 12071 +2 Misses 223 223 ``` | [Impacted Files](https://codecov.io/gh/seqan/seqan3/pull/3145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=seqan) | Coverage Δ | | |---|---|---| | [include/seqan3/io/sam\_file/header.hpp](https://codecov.io/gh/seqan/seqan3/pull/3145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=seqan#diff-aW5jbHVkZS9zZXFhbjMvaW8vc2FtX2ZpbGUvaGVhZGVyLmhwcA==) | `100.00% <ø> (ø)` | | ... and [1 file with indirect coverage changes](https://codecov.io/gh/seqan/seqan3/pull/3145/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=seqan) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=seqan). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=seqan)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

smehringer commented 1 year ago

Nice thank you :) I just reference the issue in the test. After CI is though we can merge.

eseiler commented 1 year ago

Thanks again! If you want to be added as author to header.hpp, let us know.