search

seqan / seqan3

The modern C++ library for sequence analysis. Contains version 3 of the library and API docs.
https://www.seqan.de
Other
396 stars 81 forks source link

[FIX] Missing include #3252

Closed eseiler closed 2 months ago

eseiler commented 2 months ago

Trying to write a BAM file while only using the <seqan3/io/sam_file/output.hpp> include leads to a compile error.

The reference dictionary (header.ref_dict) needs to be printed for an error message: https://github.com/seqan/seqan3/blob/f489f67d9aaa6e72dc42c59a1e5ef8fc27fec9d6/include/seqan3/io/sam_file/format_bam.hpp#L708-L713

But the corresponding debug_stream include, required by to_string, is missing.

I added a separate test for this issue as we need to include only this one header.

The header tests probably do not catch this because they do not instantiate the templates.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
seqan3 ✅ Ready (Inspect) Visit Preview May 6, 2024 0:22am
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.18%. Comparing base (f489f67) to head (ff16276).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3252 +/- ## ======================================= Coverage 98.18% 98.18% ======================================= Files 269 269 Lines 11872 11872 ======================================= Hits 11656 11656 Misses 216 216 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.