search

seqan / seqan3

The modern C++ library for sequence analysis. Contains version 3 of the library and API docs.
https://www.seqan.de
Other
406 stars 81 forks source link

[FIX] gcc-15: Better bogus memcpy fix #3278

Closed eseiler closed 1 month ago

eseiler commented 1 month ago

This partially reverts https://github.com/seqan/seqan3/commit/33f3eba4ffb7aaabf77f11af767a3ef840bba2ba

~~It fixes a new bogus memcpy error with gcc-15 (fedora build). But this one had a better stacktrace and also happens to fix the one from the linked commit.~~

From what I can tell, the compiler is confused by the optimal_column.clear() (but not horizontal_column.clear()). Seems like, for the diagnostic, it forgets that it was cleared and then weird stuff happens in resize() - only affects diagnostics, not the actual compiled code.

seqan-actions commented 1 month ago

Documentation preview available at https://docs.seqan.de/preview/seqan/seqan3/3278

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.12%. Comparing base (8c1a881) to head (ec48013).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3278 +/- ## ======================================= Coverage 98.12% 98.12% ======================================= Files 270 270 Lines 11926 11926 Branches 105 105 ======================================= Hits 11702 11702 Misses 224 224 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.