search

seqan / seqan3

The modern C++ library for sequence analysis. Contains version 3 of the library and API docs.
https://www.seqan.de
Other
411 stars 82 forks source link

[INFRA] Remove GIT_TAG for URL download #3295

Closed eseiler closed 3 weeks ago

eseiler commented 3 weeks ago

The GIT_TAG is ignored, but it causes CPM to expect a git repository. When using CPM_SOURCE_CACHE, this leads to a warning, because CPM wants to run git status in the cached directory.

seqan-actions commented 3 weeks ago

Documentation preview available at https://docs.seqan.de/preview/seqan/seqan3/3295

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.13%. Comparing base (2b5641e) to head (bdfd768). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3295 +/- ## ======================================= Coverage 98.13% 98.13% ======================================= Files 271 271 Lines 11955 11955 Branches 104 104 ======================================= Hits 11732 11732 Misses 223 223 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

eseiler commented 3 weeks ago

I just saw, the version is a hash value.... What does the hash value even mean in the case of a download only?

The URL is the archive of the commit. More or less the same as GIT_TAG ${SEQAN_SDSL_VERSION}. But, in contrast to GIT_TAG, submodules are not cloned, which takes quite a while for the SDSL.

CPM says, that in general, URL is faster than GIT_TAG, even though the latter is only a shallow clone.

SGSSGene commented 3 weeks ago

My question wasn't clear: Do we need set (SEQAN3_SDSL_VERSION 14cd017027ea742353fc5b500d1cb1d95896b77e)? are we using it anywhere?

eseiler commented 3 weeks ago

My question wasn't clear: Do we need set (SEQAN3_SDSL_VERSION 14cd017027ea742353fc5b500d1cb1d95896b77e)? are we using it anywhere?

We don't really need it, except maybe for the latest library cron, where it would be harder to search+replace the versions; though we could use the local package override mechanism.

As far as I know, there's not really a way to get the CPM package version/tag programmatically, at least it's not advertised.