search

seqeralabs / cx-field-tools-installer

Unofficial Terraform solution to help clients install Seqera Platform
Apache License 2.0
3 stars 1 forks source link

[ Maintenance ] Consider loosening AWS Provider pinning #158

Open gwright99 opened 3 hours ago

gwright99 commented 3 hours ago

The current solution is tightly pinned to the 5.12.x version of the TF AWS Provider.

The current configuration version = "~> 5.12.0" means that the patch version can increment, but not the major or - more importantly - the minor version.

For ongoing maintenance efforts and acquisition of functionality in the 5.x.x series, it may be preferable to implement a different strategy like: version = ">= 5.12.0, < 6.0.0". This is both:

  1. Explicit (and generally more clear than the equivalent ~> shorthand).
  2. Provides an opportunity to easily grab new features/fixes via terraform init -upgrade.

There is a downside, however, in that some organizations' change control processes may not allow these looser pinning. Further investigation required.

gwright99 commented 3 hours ago

@schaluva -- any thoughts on the topic above?

schaluva commented 2 hours ago

Initial thought is to not loosen the constraint so as not to introduce another point of potential variability. There are already lots of knobs and levers that can be configured differently across users of the installer so I think if efforts of changing the pinned version are not too high, it feels safer to have the pinned version.