Bump gradle version to 8.4

seqeralabs / wave-cli

Command line tool for Wave containers provisioning service

https://seqera.io/wave

Apache License 2.0

13 stars 3 forks source link

Bump gradle version to 8.4 #39

Closed marcodelapierre closed 1 year ago

marcodelapierre commented 1 year ago

This PR will upgrade gradle to 8.4

marcodelapierre commented 1 year ago

From Munish:

tests were skipped
https://github.com/gradle/gradle/issues/26061
upgrading buildtool version seems to fix the issue, account to the comments, i will try that

munishchouhan commented 1 year ago

PR with fix https://github.com/seqeralabs/wave-cli/pull/40

pditommaso commented 1 year ago

Why tests were skipped by the CI?

marcodelapierre commented 1 year ago

I remember this has happened before with another PR of mine.

One thing I can think of is that, as the change was little, I edited directly in the github web interface, then asked to commit on new branch, which I then submitted for PR .. wondering whether this workflow works in a different way compared to a push from local repo .. it shouldn't right?

Can investigate further

marcodelapierre commented 1 year ago

See https://github.com/seqeralabs/wave-cli/pull/44