search

seqeralabs / wave-cli

Command line tool for Wave containers provisioning service
https://seqera.io/wave
Apache License 2.0
13 stars 3 forks source link

Fix build warnings and release error #51

Closed munishchouhan closed 11 months ago

munishchouhan commented 11 months ago

This PR will fix build warnings and release error:

  1. remove components: 'native-image', which is no more required in Java 21
  2. Added Java version in jreleaser.yml required by fatjar
pditommaso commented 11 months ago

Should this fix the release?

munishchouhan commented 11 months ago

Should this fix the release?

I am testing if these warnings are the reasons for the release skip https://github.com/munishchouhan/wave-cli/actions/runs/7266156843

munishchouhan commented 11 months ago

These warnings are not the reason of release skip Now I am testing with the new changes we made after the last release https://github.com/munishchouhan/wave-cli/actions/runs/7266051892

munishchouhan commented 11 months ago

found one error in release job, latest commit will fix it this maybe the cause 

Error:  == JReleaser ==
Error:  distribution.wave-cli-jar.type is set to SINGLE_JAR but neither distribution.wave-cli-jar.java nor project.java have been set
JReleaser has not been properly configured.
distribution.wave-cli-jar.type is set to SINGLE_JAR but neither distribution.wave-cli-jar.java nor project.java have been set

Error: Process completed with exit code 1.
munishchouhan commented 11 months ago

@pditommaso please review