seqeralabs / wave-cli

Command line tool for Wave containers provisioning service
https://seqera.io/wave
Apache License 2.0
13 stars 3 forks source link

Add support for namingStrategy request attribute #69

Closed pditommaso closed 1 month ago

pditommaso commented 6 months ago

The goal of this issue is to support the naming strategy request attribute in the wave CLI.

This could be now implemented via nameStrategy attribute.

pditommaso commented 6 months ago

Trying this with

wave --conda cowpy --freeze --build-repo docker.io/pditommaso/wave-test --dry-run --name-strategy imageSuffix

it returns

docker.io/pditommaso/wave-test:cowpy--687bcba781ef4f5d

instead it should be

docker.io/pditommaso/wave-test/cowpy:687bcba781ef4f5d

tho it may be a backend problem

munishchouhan commented 6 months ago

I will check it out

munishchouhan commented 6 months ago

I tested it through API call got the same think:

Screenshot 2024-05-21 at 22 42 25
munishchouhan commented 6 months ago

but while testing i found another issue pr for fix: https://github.com/seqeralabs/wave-cli/pull/72

pditommaso commented 6 months ago

Still not working in my tests

https://github.com/seqeralabs/wave-cli/issues/69#issuecomment-2123208128

munishchouhan commented 6 months ago

Still not working in my tests

#69 (comment)

yes, because its an issue in backend I tried using wave API https://github.com/seqeralabs/wave-cli/issues/69#issuecomment-2123409992 and got the same result as https://github.com/seqeralabs/wave-cli/issues/69#issuecomment-2123208128

I will open an issue in wave to fix it

munishchouhan commented 6 months ago

issue created https://github.com/seqeralabs/wave/issues/507

munishchouhan commented 1 month ago

already completed https://github.com/seqeralabs/wave/issues/507