sequelize / cli

The Sequelize CLI
MIT License
2.52k stars 528 forks source link

refactor: switch cli-color to ansis #1507

Closed webdiscus closed 1 month ago

webdiscus commented 1 month ago

Pull Request check-list

Please make sure to review and check all of these items:

Description of change

Hello @WikiRik,

I'm the author of the ansis which you already know.

This PR switch the cli-color to ansis package, because:

Screenshot 2024-06-07 at 11 43 33 Screenshot 2024-06-07 at 11 44 03

webdiscus commented 1 month ago

@WikiRik

should the sequelize-cli package really supports node-10 in 2024? I can add the supports for node-10, if it is need. Maybe change the CI test from node-version: [10, 16] to [16, 18, 20]? The sequelize uses node-version: [18, 20] for testing.

WikiRik commented 1 month ago

We're replacing sequelize-cli with @sequelize/cli in v7 (which is in the monorepo you've already updated). For v6 (the current version) we will keep supporting Node 10, so I'll close this PR since we have no need to switch here. Thanks for opening the PR anyway!