search

sequelize / cli

The Sequelize CLI
MIT License
2.53k stars 528 forks source link

Support Unix sockets in --url #695

Open jo-so opened 5 years ago

jo-so commented 5 years ago

I would like to access my database via Unix socket. This requires to use a path as hostname, but not all path characters are valid for a hostname. Rust's r2d2 database driver uses an URL-encoded form of the hostname like: postgres://joerg@%2Frun%2Fpostgresql:5433/codimd?application_name=CodiMD. Maybe you could support this, too. Or use a query parameter for this.

bogdan commented 5 years ago

Sequelize itself supports a socket given as a host parameter like:

postgres://postgres@/unstoppable_website_development?host=/tmp

But not sequelize-cli

Its weird that sequelize-cli doesn't reuse that code from sequelize itself.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

jo-so commented 4 years ago

I think it's up to the devs to implement this request. This issue stalled, because the devs didn't react.

sushantdhiman commented 4 years ago

Tagging this as feature request

I think it's up to the devs to implement this request. This issue stalled, because the devs didn't react.

@jo-so I don't have infinite time at my hand. I will appreciate a PR with proper test

jo-so commented 4 years ago

Does the feature tag keep away the stale bot?

sushantdhiman commented 4 years ago

Yes, but issues will be disabled soon and only PRs will be accepted, so it wont matter if issue is closed or open