search

sequelize / express-example

A proposal for the usage of Sequelize within an Express.JS application.
MIT License
2.5k stars 770 forks source link

upgrade packages #101

Closed colinwitkamp closed 4 years ago

colinwitkamp commented 4 years ago

Resolved:

colinwitkamp commented 4 years ago

I think we don't need pg as it is using sqlite for db. To make it minimalistic, I removed it.

On Mon, Jun 15, 2020 at 7:57 PM Pedro Augusto de Paula Barbosa < notifications@github.com> wrote:

@papb commented on this pull request.

In package.json https://github.com/sequelize/express-example/pull/101#discussion_r440123646 :

@@ -9,23 +9,22 @@ "test-integration": "cross-env NODE_ENV=test ./node_modules/.bin/mocha test/integration/*.test.js" }, "dependencies": {

  • "bluebird": "^3.5.1",
  • "body-parser": "^1.18.2",
  • "cookie-parser": "^1.4.3",
  • "debug": "^3.1.0",
  • "express": "^4.16.2",
  • "morgan": "^1.7.0",
  • "pg": "^6.1.0",

Why did you remove pg?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sequelize/express-example/pull/101#pullrequestreview-430573042, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD7M5WMZZTBOXC5NZ7EJSVLRWYEB5ANCNFSM4N6CTCUA .

papb commented 4 years ago

@colinwitkamp Thanks, that makes sense. I will not merge yet just to make some other tests, I plan to improve this package as a whole in the near future.

sushantdhiman commented 4 years ago

@papb Nice, Actually it will make sense to convert this repo to a multi-repo with various examples. We can start with examples/express as a start and add other examples like examples/express-with-typescript etc

colinwitkamp commented 4 years ago

okay, no problem,

On Mon, Jun 15, 2020 at 8:05 PM Pedro Augusto de Paula Barbosa < notifications@github.com> wrote:

@colinwitkamp https://github.com/colinwitkamp Thanks, that makes sense. I will not merge yet just to make some other tests, I plan to improve this package as a whole in the near future.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sequelize/express-example/pull/101#issuecomment-644088405, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD7M5WN2FFLEK3X7BYMCDQLRWYFCDANCNFSM4N6CTCUA .

papb commented 4 years ago

Thank you!! :tada: