sequelize / express-example

A proposal for the usage of Sequelize within an Express.JS application.

MIT License

2.5k stars 770 forks source link

Model names using Upper Camel Case should be more clear #50

Closed arturojain closed 8 years ago

arturojain commented 8 years ago

49

mention-bot commented 8 years ago

@arturojain, thanks for your PR! By analyzing the history of the files in this pull request, we identified @sdepold and @uwolfer to be potential reviewers.

sushantdhiman commented 8 years ago

Hi @arturojain , Thanks for this contribution. I can't accept this PR because

1, These are auto generated files so I would prefer to keep them as they are originally generated 2, Upper case is not required, you can choose lower case as well like

var task = Sequelize.define('task', {
    id: Datatypes.INTEGER
});

// then access as
models.task

3, I think its documentation role to convey this information, not example repository.