search

sequelize / sequelize-pool

Resource pool implementation. It can be used to throttle expensive resources.
Other
38 stars 17 forks source link

Ensure pool uses existing client on a LIFO basis #11

Closed holm closed 5 years ago

holm commented 5 years ago

The documentation claimed that the pool was LIFO, but in practice it was not. I suspect this is the reason the pool grows more than required, as clients are constantly cycled through, and thus never reaches their idle time, unless usage essentially stops.

This should fix https://github.com/sequelize/sequelize/issues/10907 and the original report in https://github.com/sequelize/sequelize/issues/10902.

sushantdhiman commented 5 years ago

+ sequelize-pool@2.3.0

sushantdhiman commented 5 years ago

+ sequelize@5.9.1

holm commented 5 years ago

Thanks for the quick turnaround on this