search

sequelize / sequelize-pool

Resource pool implementation. It can be used to throttle expensive resources.
Other
39 stars 17 forks source link

refactor: remove bluebird #2

Closed SimonSchick closed 5 years ago

SimonSchick commented 5 years ago

Currently playing around with removing bluebird.

Breaking changes are: 1) No more bluebird (duh) 2) Using own TimeoutError.

If possible I'd like to get this released as a major RC.

DiegoRBaquero commented 5 years ago

Honest question, why was bluebird used when moving from node-pool?

I feel like Bluebird could be removed from sequelize as a whole, but maybe there's a reason as to why it is there.

SimonSchick commented 5 years ago

@DiegoRBaquero I have no idea, probably consistency/ease of use. I'm playing around with purging bluebird from sequelize but that's a lot of work.

SimonSchick commented 5 years ago

@DiegoRBaquero actually, sequelize has been around longer than the native promise implementations were near stable enough to use. With modern async/await it's fair to consider it's removal.

DiegoRBaquero commented 5 years ago

Yes, I'm coming from the basis that sequelize v5 uses Node 6+, which is where node-pool was removed. So we can consider removing it and use the native implementation.

SimonSchick commented 5 years ago

@sushantdhiman could you please perform a major RC release? Might also move this to the sequelize org :)