search

sequelize / sequelize-pool

Resource pool implementation. It can be used to throttle expensive resources.
Other
38 stars 17 forks source link

Moving sequelize-pool inside sequelize monorepo #54

Open WikiRik opened 5 months ago

WikiRik commented 5 months ago

This message is mostly for @sushantdhiman but others are welcome to chime in as well.

As you might have seen, sequelize has been a monorepo for a while now. With the release of v7 nearing we want to move other repositories like sequelize-cli and the unmaintained pg-hstore towards the monorepo as well. Would you be okay if we move sequelize-pool in there as well and release future major releases as @sequelize/pool? A while back we've had the same discussion for umzug but because there are various use cases outside of sequelize we decided that it will remain it's own repository. So we're able to go both ways but we'd like your input on this.

cc @ephys

sushantdhiman commented 5 months ago

Hi @WikiRik,

I am ok with publishing new releases under @sequelize/pool, but I am against moving this project to monorepo because

  1. Issues related to pool will get lost with all the other noise. It won't be possible for me to triage pool related issues and then continue discussions with the monorepo setup. 
  2. Pool code is independent, it can get major releases regardless of the core project release schedule. With monorepo, I think you wish to keep versions in sync for all sub-projects?
ephys commented 5 months ago

Issues related to pool will get lost with all the other noise.

That's definitely fair, and I want to be clear that it's not something we want to impose

With monorepo, I think you wish to keep versions in sync for all sub-projects?

That's currently true but that's something I'd like to change. It makes sense to keep the dialect package versions in sync with core, but packages like utils, pg-hstore and toposort shouldn't be