search

sequelize / umzug

Framework agnostic migration tool for Node.js
MIT License
1.98k stars 158 forks source link

Provide charset and collate options only for dialects supporting them #624

Closed QuentinFarizon closed 8 months ago

QuentinFarizon commented 8 months ago

Fixes https://github.com/sequelize/umzug/issues/612

Fixes https://github.com/sequelize/umzug/issues/623

QuentinFarizon commented 8 months ago

@WikiRik I'm not sure how to correct the typescript error

WikiRik commented 8 months ago

You'll need to update the minimal type here to add the dialect property; https://github.com/sequelize/umzug/blob/main/src/storage/sequelize.ts#L21-L30

WikiRik commented 8 months ago

We're one step further, now the linting issues commence

github-actions[bot] commented 8 months ago

Released in v3.4.0.

github-actions[bot] commented 8 months ago

Released in v3.4.0.