sequelize / umzug

Framework agnostic migration tool for Node.js
MIT License
1.98k stars 158 forks source link

Glob v10 does not support Node 12 #659

Closed mmkal closed 3 months ago

mmkal commented 3 months ago

Originally posted by @WikiRik in https://github.com/sequelize/umzug/issues/658#issuecomment-2024450009

Suggested fix: switch to fast-glob

glob has a helpful comparison section:

# Comparison to Other JavaScript Glob Implementations If you want glob matching that is as faithful as possible to Bash pattern expansion semantics, and as fast as possible within that constraint, use this module. If you are reasonably sure that the patterns you will encounter are relatively simple, and want the absolutely fastest glob matcher out there, use [fast-glob](http://npm.im/fast-glob). If you are reasonably sure that the patterns you will encounter are relatively simple, and want the convenience of automatically respecting .gitignore files, use [globby](http://npm.im/globby). There are some other glob matcher libraries on npm, but these three are (in my opinion, as of 2023) the best.

I think it's pretty safe to assume the migration globs are simple enough for fast-glob to work for the vast majority of users. If not, they're hopefully advanced users and could always pass an array of migrations built via glob anyway.

github-actions[bot] commented 3 months ago

Released in v3.8.0.