sequelize / umzug

Framework agnostic migration tool for Node.js
MIT License
1.98k stars 158 forks source link

fix: restore node12 support (glob -> fast-glob) #660

Closed mmkal closed 3 months ago

mmkal commented 3 months ago

fixes #659

Note that there are some edge-case differences between glob and fast-glob, but it's very unlikely that users of umzug will hit them.

See glob docs for an in-depth comparison: https://github.com/isaacs/node-glob?tab=readme-ov-file#comparison-to-other-javascript-glob-implementations

If there's anyone that needs the old glob behaviour, they can use glob themselves and pass an array of migrations to umzug. (see https://github.com/sequelize/umzug#direct-migrations-list)

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.45%. Comparing base (e4f7865) to head (7fabcb4).

:exclamation: Current head 7fabcb4 differs from pull request most recent head 94ff029. Consider uploading reports for the commit 94ff029 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #660 +/- ## ======================================= Coverage 99.45% 99.45% ======================================= Files 12 12 Lines 1465 1466 +1 Branches 268 269 +1 ======================================= + Hits 1457 1458 +1 Misses 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mmkal commented 3 months ago

CC @WikiRik any feedback on this change?

WikiRik commented 3 months ago

I don't have enough insights in the usages of umzug and the globs people use. So I can't say much on this.

It seems that there are well documented changes between the two libraries that people can refer to and the added benefit is that the indirect vulnerable dependency is resolved without dropping Node 12 support.

mmkal commented 3 months ago

Agreed. I am working on a change to CI which will highlight that node 12/node 14 support is broken currently. I'll merge that first, which should make CI go red, then confirm that this change fixes it.

github-actions[bot] commented 3 months ago

Released in v3.8.0.