bug: error with charset & collate in postgres with v7

sequelize / umzug

Framework agnostic migration tool for Node.js

MIT License

2.01k stars 158 forks source link

bug: error with charset & collate in postgres with v7 #671

Closed EinfachHans closed 4 months ago

EinfachHans commented 4 months ago

In #624 (about issue #612) the charset and collate options are set to null if not supported by dialect. With latest v7 alpha i get the following error:

Error: The following options are not supported by createTableQuery in postgres: charset, collate

Setting the values to undefined instead of null works for me.

If you want to i can create a PR 😊

WikiRik commented 4 months ago

Undefined sounds good, feel free to open the PR

EinfachHans commented 4 months ago

PR opened: #673 😊

github-actions[bot] commented 4 months ago

Released in v3.8.1.