Open ephys opened 2 years ago
Do we want to fix all of these? Or just the v6 and v7 links?
Just v6 for the initial release. I think fixing the archives would be welcomed but not important.
I'm re-running the script to know which pages include these broken URLs.
breakdown of broken URLs:
It's already broken on the existing site - not blocking
The following URLs are esdocs failing to generate the api reference for those files:
It's already broken on the existing site - not blocking
Not blocking, archived version
broken links on https://sequelize-site.netlify.app/v3/docs/models-definition/ :
404: https://sequelize-site.netlify.app/v3/docs/api/datatypes
404: https://sequelize-site.netlify.app/v3/docs/models-definition/transactions/
broken links on https://sequelize-site.netlify.app/v3/docs/scopes/ :
404: https://sequelize-site.netlify.app/v3/docs/scopes/associations/
broken links on https://sequelize-site.netlify.app/v3/docs/associations/ :
404: https://sequelize-site.netlify.app/v3/docs/associations/scopes
broken links on https://sequelize-site.netlify.app/v3/docs/hooks/ :
404: https://sequelize-site.netlify.app/api/hooks
broken links on https://sequelize-site.netlify.app/v3/api/sequelize/ :
404: https://sequelize-site.netlify.app/v3/api/sequelize/sequelize
404: https://sequelize-site.netlify.app/v3/api/sequelize/transaction
404: https://sequelize-site.netlify.app/v3/api/sequelize/deferrable
404: https://sequelize-site.netlify.app/v3/api/sequelize/instance
404: https://sequelize-site.netlify.app/v3/api/sequelize/association
404: https://sequelize-site.netlify.app/v3/api/sequelize/errors
404: https://sequelize-site.netlify.app/v3/api/sequelize/queryinterface
404: https://sequelize-site.netlify.app/v3/api/sequelize/datatypes
404: https://sequelize-site.netlify.app/v3/api/sequelize/hooks
404: https://sequelize-site.netlify.app/v3/api/sequelize/model
broken links on https://sequelize-site.netlify.app/v3/api/model/ :
404: https://sequelize-site.netlify.app/v3/api/model/sequelize
404: https://sequelize-site.netlify.app/v3/api/model/transaction
404: https://sequelize-site.netlify.app/v3/api/model/model
404: https://sequelize-site.netlify.app/v3/api/model/instance
broken links on https://sequelize-site.netlify.app/v3/api/instance/ :
404: https://sequelize-site.netlify.app/v3/api/instance/sequelize
404: https://sequelize-site.netlify.app/v3/api/instance/model
404: https://sequelize-site.netlify.app/v3/api/instance/instancevalidator
404: https://sequelize-site.netlify.app/v3/api/instance/instance
broken links on https://sequelize-site.netlify.app/v3/api/associations/belongs-to/ :
404: https://sequelize-site.netlify.app/v3/sequelize/
404: https://sequelize-site.netlify.app/v3/model/
404: https://sequelize-site.netlify.app/v3/instance/
404: https://sequelize-site.netlify.app/v3/api/
404: https://sequelize-site.netlify.app/v3/api/has-one/
404: https://sequelize-site.netlify.app/v3/api/has-many/
404: https://sequelize-site.netlify.app/v3/api/belongs-to-many/
404: https://sequelize-site.netlify.app/v3/hooks/
404: https://sequelize-site.netlify.app/v3/transaction/
404: https://sequelize-site.netlify.app/v3/datatypes/
404: https://sequelize-site.netlify.app/v3/deferrable/
404: https://sequelize-site.netlify.app/v3/errors/
broken links on https://sequelize-site.netlify.app/v3/api/associations/has-one/ :
404: https://sequelize-site.netlify.app/v3/sequelize/
404: https://sequelize-site.netlify.app/v3/model/
404: https://sequelize-site.netlify.app/v3/instance/
404: https://sequelize-site.netlify.app/v3/api/
404: https://sequelize-site.netlify.app/v3/api/belongs-to/
404: https://sequelize-site.netlify.app/v3/api/has-many/
404: https://sequelize-site.netlify.app/v3/api/belongs-to-many/
404: https://sequelize-site.netlify.app/v3/hooks/
404: https://sequelize-site.netlify.app/v3/transaction/
404: https://sequelize-site.netlify.app/v3/datatypes/
404: https://sequelize-site.netlify.app/v3/deferrable/
404: https://sequelize-site.netlify.app/v3/errors/
broken links on https://sequelize-site.netlify.app/v3/api/associations/has-many/ :
404: https://sequelize-site.netlify.app/v3/sequelize/
404: https://sequelize-site.netlify.app/v3/model/
404: https://sequelize-site.netlify.app/v3/instance/
404: https://sequelize-site.netlify.app/v3/api/
404: https://sequelize-site.netlify.app/v3/api/belongs-to/
404: https://sequelize-site.netlify.app/v3/api/has-one/
404: https://sequelize-site.netlify.app/v3/api/belongs-to-many/
404: https://sequelize-site.netlify.app/v3/hooks/
404: https://sequelize-site.netlify.app/v3/transaction/
404: https://sequelize-site.netlify.app/v3/datatypes/
404: https://sequelize-site.netlify.app/v3/deferrable/
404: https://sequelize-site.netlify.app/v3/errors/
broken links on https://sequelize-site.netlify.app/v3/api/associations/belongs-to-many/ :
404: https://sequelize-site.netlify.app/v3/sequelize/
404: https://sequelize-site.netlify.app/v3/model/
404: https://sequelize-site.netlify.app/v3/instance/
404: https://sequelize-site.netlify.app/v3/api/
404: https://sequelize-site.netlify.app/v3/api/belongs-to/
404: https://sequelize-site.netlify.app/v3/api/has-one/
404: https://sequelize-site.netlify.app/v3/api/has-many/
404: https://sequelize-site.netlify.app/v3/hooks/
404: https://sequelize-site.netlify.app/v3/transaction/
404: https://sequelize-site.netlify.app/v3/datatypes/
404: https://sequelize-site.netlify.app/v3/deferrable/
404: https://sequelize-site.netlify.app/v3/errors/
broken links on https://sequelize-site.netlify.app/v3/api/hooks/ :
404: https://sequelize-site.netlify.app/v3/api/hooks/sequelize
Not blocking, archived version
broken links on https://sequelize-site.netlify.app/v2/ :
404: https://sequelize-site.netlify.app/v2/docs/misc
404: https://sequelize-site.netlify.app/v2/imprint
broken links on https://sequelize-site.netlify.app/v2/api/sequelize/ :
404: https://sequelize-site.netlify.app/v2/sequelize
404: https://sequelize-site.netlify.app/v2/utils
404: https://sequelize-site.netlify.app/v2/promise
404: https://sequelize-site.netlify.app/v2/transaction
404: https://sequelize-site.netlify.app/v2/instance
404: https://sequelize-site.netlify.app/v2/errors
404: https://sequelize-site.netlify.app/v2/queryinterface
404: https://sequelize-site.netlify.app/v2/migrator
404: https://sequelize-site.netlify.app/v2/datatypes
404: https://sequelize-site.netlify.app/v2/hooks
404: https://sequelize-site.netlify.app/v2/model
broken links on https://sequelize-site.netlify.app/v2/articles/getting-started/ :
404: https://sequelize-site.netlify.app/v2//docs/latest/migrations
404: https://sequelize-site.netlify.app/v2//docs/latest/models
404: https://sequelize-site.netlify.app/v2//docs/latest/associations
broken links on https://sequelize-site.netlify.app/v2/docs/usage/ :
404: https://sequelize-site.netlify.app/v2//docs/latest/usage
broken links on https://sequelize-site.netlify.app/v2/docs/models/ :
404: https://sequelize-site.netlify.app/v2//docs/latest/misc
broken links on https://sequelize-site.netlify.app/v2/api/model/ :
404: https://sequelize-site.netlify.app/v2/sequelize
404: https://sequelize-site.netlify.app/v2/model
404: https://sequelize-site.netlify.app/v2/instance
broken links on https://sequelize-site.netlify.app/v2/api/instance/ :
404: https://sequelize-site.netlify.app/v2/sequelize
404: https://sequelize-site.netlify.app/v2/model
404: https://sequelize-site.netlify.app/v2/instance
404: https://sequelize-site.netlify.app/v2/instancevalidator
broken links on https://sequelize-site.netlify.app/v2/api/hooks/ :
404: https://sequelize-site.netlify.app/v2/sequelize
Only blocker is this:
broken links on https://sequelize-site.netlify.app/docs/v7/getting-started/ :
404: https://sequelize-site.netlify.app/v6/manual/getting-started.html
In the API reference of v6 when you click the bold API Reference link you get referred to the missing page of https://sequelize.org/api/v6/manual/index.html
I tried fixing the missing pages in the v6 api reference. It's caused by esdoc failing to parse the new syntax. I tried transpiling the files using esbuild first, but esbuild doesn't place the comments in the right place so the files are empty and useless.
The only way to repair them would be to update their source code to manually replace the new syntax with syntax compatible with esdoc
The only way to update them would be to update their source code to manually replace the new syntax with syntax compatible with esdoc
Guess that's what we have to do then unfortunately. Don't think we want to keep that out of the docs for much longer.
@ephys not sure if you shared your script before, but can you run it again?
My script is available here: https://github.com/ephys/puppeteer-crawler
The command I use to check sequelize is:
npm start https://sequelize.org -- --collect-meta=anchors \
--exclude-path='/v{1,2,3,4,5}' \
--exclude-path='/v{1,2,3,4,5}/**/*' \
--exclude-path='/api/**/*' \
--exclude-path='/api' \
--check-externals
This causes it to check that all pages linked from anything except the above excluded paths are not 404s
Then npm run print-broken-links
can be used to print a readable list of 404s
It's a rough script that always requires some tinkering though
Here is the latest run:
broken links on https://sequelize.org/docs/v6/other-topics/upgrade/ :
404: https://github.com/sequelize/sequelize11778/pull/
404: https://github.com/sequelize/sequelize11775/pull/
broken links on https://sequelize.org/docs/v6/other-topics/aws-lambda/ :
404: https://nodejs.org/en/docs/guides/event-loop-timers-and-nexttick/
404: https://sequelize.org/api/v6/class/src/errors/connection/connection-acquire-timeout-error.js~ConnectionAcquireTimeoutError.html
broken links on https://sequelize.org/docs/v6/other-topics/resources/ :
404: https://www.pg-generator.com/builtin-templates/sequelize/
broken links on https://sequelize.org/docs/v7/models/data-types/ :
404: https://sequelize.org/api/v7/classes/_sequelize_core.index.unknown.STRING.html
404: https://sequelize.org/api/v7/classes/_sequelize_core.index.unknown.TEXT.html
404: https://sequelize.org/api/v7/classes/_sequelize_core.index.unknown.CHAR.html
404: https://sequelize.org/api/v7/classes/_sequelize_core.index.unknown.TINYINT.html
404: https://sequelize.org/api/v7/classes/_sequelize_core.index.unknown.SMALLINT.html
404: https://sequelize.org/api/v7/classes/_sequelize_core.index.unknown.MEDIUMINT.html
404: https://sequelize.org/api/v7/classes/_sequelize_core.index.unknown.INTEGER.html
404: https://sequelize.org/api/v7/classes/_sequelize_core.index.unknown.BIGINT.html
404: https://sequelize.org/api/v7/classes/_sequelize_core.index.unknown.FLOAT.html
404: https://sequelize.org/api/v7/classes/_sequelize_core.index.unknown.DOUBLE.html
404: https://sequelize.org/api/v7/classes/_sequelize_core.index.unknown.DECIMAL.html
404: https://sequelize.org/api/v7/classes/_sequelize_core.index.unknown.DATE.html
404: https://sequelize.org/api/v7/classes/_sequelize_core.index.unknown.BLOB.html
404: https://sequelize.org/api/v7/classes/_sequelize_core.index.unknown.ENUM.html
404: https://sequelize.org/api/v7/classes/_sequelize_core.index.unknown.GEOMETRY.html
404: https://sequelize.org/api/v7/classes/_sequelize_core.index.unknown.GEOGRAPHY.html
broken links on https://sequelize.org/docs/v7/models/inheritance/ :
404: https://sequelize.org/v7/variables/_sequelize_core.decorators_legacy.table.abstract
404: https://sequelize.org/api/v7/functions/_sequelize_core.decorators_legacy.table-1
broken links on https://sequelize.org/docs/v7/other-topics/aws-lambda/ :
404: https://nodejs.org/en/docs/guides/event-loop-timers-and-nexttick/
broken links on https://sequelize.org/docs/v7/other-topics/connection-pool/ :
404: https://sequelize.org/api/v7/classes/_sequelize_core.index.unknown.ReplicationPool.html
broken links on https://sequelize.org/docs/v7/other-topics/upgrade/ :
404: https://sequelize.org/api/v7/variables/_sequelize_core.index.sql.literal.html
404: https://sequelize.org/api/v7/variables/_sequelize_core.index.sql.col.html
404: https://sequelize.org/api/v7/variables/_sequelize_core.index.sql.fn.html
broken links on https://sequelize.org/api/v6/class/src/model.js~model :
404: https://sequelize.org/api/v6/source.html
404: https://sequelize.org/api/v6/file/src/model.js.html
Just ran my script on the latest preview, here is the complete list of broken internal URLs: