search

sequenceiq / hadoop-docker

Hadoop docker image
https://registry.hub.docker.com/u/sequenceiq/hadoop-docker/
Apache License 2.0
1.21k stars 561 forks source link

Parametrize the Java download URL, and default it to Java 8. #57

Closed ldcasillas-progreso closed 8 years ago

ldcasillas-progreso commented 8 years ago

As in the title.

There's another open pull request (https://github.com/sequenceiq/hadoop-docker/pull/38) that also switches to Java 8. This one differs in that it doesn't hardcode the Java download URL, but rather specifies it as an ARG in the Dockerfile.

It's late 2016, Java 8 is very common already, and it can run code from older Java versions, so I suggest that it should be the default here. But changing the default JAVA_URL to Java 7 (which requires users to pass a custom argument at build time) is an alternative as well.

lalyos commented 8 years ago

Closing as duplicated of: #38