serai-dex / serai

Other
262 stars 49 forks source link

Add lint for HashMap iteration #424

Open kayabaNerve opened 11 months ago

kayabaNerve commented 11 months ago

https://github.com/rust-lang/rust/pull/92584 created a compiler-internal lint for unstable iterations over HashMaps. Ideally, we can lift it into https://github.com/trailofbits/dylint and run it over Serai to ensure we aren't expecting stable iteration from something with an unstable insertion order.

I also requested this as a clippy lint in https://github.com/rust-lang/rust-clippy/issues/11788.

kayabaNerve commented 10 months ago

Just waiting for the above clippy to hit nightly.