search

serai-dex / serai

Other
255 stars 47 forks source link

#560 take two, now that #560 has been reverted #561

Closed kayabaNerve closed 2 months ago

kayabaNerve commented 5 months ago

https://github.com/serai-dex/serai/commit/933b17aa911d1b27c8c76d5c4715b329d6cbfa5a for the comments on why this was reverted.

There's probably some typo/massive perf issue here needing resolving? Rebroadcasting frequency?

kayabaNerve commented 5 months ago

The upons fix is critical for consensus, the round proposal part is an efficiency improvement (as off-hand, I'd assume this lib is slower than the prior lib, even if it's clearer and capable of being audited).

kayabaNerve commented 2 months ago

:partying_face:

@akildemir for the credit on this crossing the finish line.