seraphx2 / ESI.NET

A C# wrapper for the Eve Online ESI API.
https://www.nuget.org/packages/ESI.NET/
MIT License
42 stars 25 forks source link

starbase_id in Starbase within CorporationLogic.cs should be type of long #12

Closed DanFraserUK closed 5 years ago

DanFraserUK commented 5 years ago

Silly little change but stops having to recast the id in starbase.cs.

Btw, I have no idea if this is something I can change in github, if i can, show me lol.

seraphx2 commented 5 years ago

the only way you could change it directly in github is if I gave out contributor rights, I think. However, typical process is to fork/download the code, make the change and do a Pull Request that I would approve and merge.

DanFraserUK commented 5 years ago

Ah right. Well, being a complete idiotic noob I'm failing just trying to put my own project on github!

seraphx2 commented 5 years ago

i'll have the type changed in a little bit. I also am formatting the code for readability in all the files and i happened to find a small bug doing so, sooo, lol. i'm almost done. Discord will have a notification when the new version is just about ready.