seraphx2 / ESI.NET

A C# wrapper for the Eve Online ESI API.
https://www.nuget.org/packages/ESI.NET/
MIT License
44 stars 25 forks source link

SystemSovereignty only contains faction_id #14

Closed BitBaboonSteve closed 5 years ago

BitBaboonSteve commented 5 years ago

The ESI.NET.Models.Sovereignty.SystemSovereignty only contains the faction_id; yet this can return both a corp corporation_id and an alliance id.

DanFraserUK commented 5 years ago

From the /sovereignty/map/ endpoint?

Proposed fix: public class SystemSovereignty { [JsonProperty("alliance_id")] public int AllianceId { get; set; } [JsonProperty("corporation_id")] public int CorporationId { get; set; } [JsonProperty("faction_id")] public int FactionId { get; set; } [JsonProperty("system_id")] public int SystemId { get; set; } }

Temporary fix for users of ESI.NET: public class SystemSovereigntyTemp : SystemSovereignty { [JsonProperty("alliance_id")] public int AllianceId { get; set; } [JsonProperty("corporation_id")] public int CorporationId { get; set; } }