seraphx2 / ESI.NET

A C# wrapper for the Eve Online ESI API.
https://www.nuget.org/packages/ESI.NET/
MIT License
42 stars 25 forks source link

RefId returns 0 from JournalEntry #17

Closed mrurb closed 5 years ago

mrurb commented 5 years ago

RefId seems to return 0, from what i can see the model uses a long, but the documentation says it should be an int64. Not sure if this is the problem, but all RefId returns 0 for me. image

seraphx2 commented 5 years ago

int is an alias for Int32. long is an alias for Int64. So that should not be the problem. i will look into it and see what's going on.

seraphx2 commented 5 years ago

Oh, it looks like you are still using an old version of the API. I upgraded a few days ago to address the new versions of the journal endpoints in 2.9.8 (even before I fixed the paging issue for you in 2.10.8) and RefId is no longer in there, along with "ExtraInfo" and the PartyType properties.

Please upgrade to 2.10.8

https://github.com/seraphx2/ESI.NET/releases

[JsonProperty("amount")]
public decimal Amount { get; set; }

[JsonProperty("balance")]
public decimal Balance { get; set; }

[JsonProperty("context_id")]
public long ContextId { get; set; }

[JsonProperty("context_id_type")]
public string ContextIdType { get; set; }

[JsonProperty("date")]
public string Date { get; set; }

[JsonProperty("description")]
public string Description { get; set; }

[JsonProperty("first_party_id")]
public int FirstPartyId { get; set; }

[JsonProperty("id")]
public long Id { get; set; }

[JsonProperty("reason")]
public string Reason { get; set; }

[JsonProperty("ref_type")]
public string RefType { get; set; }

[JsonProperty("second_party_id")]
public int SecondPartyId { get; set; }

[JsonProperty("tax")]
public decimal Tax { get; set; }

[JsonProperty("tax_receiver_id")]
public int TaxReceiverId { get; set; }
mrurb commented 5 years ago

Hmm that’s interesting, because I updated to the new version from nuget(2.10.8) and I’m using the new page logic that you put in, but what I posted above is what I get back after updating, I will have a further look at it tomorrow.

seraphx2 commented 5 years ago

OK. Definitely interesting because I'm looking at both develop and master branches and the new class properties are definitely there.