seraphx2 / ESI.NET

A C# wrapper for the Eve Online ESI API.
https://www.nuget.org/packages/ESI.NET/
MIT License
42 stars 25 forks source link

Error being thrown on Type - Mass #2

Closed Monkey7539 closed 6 years ago

Monkey7539 commented 6 years ago

Error being thrown by scientific notation Mass's at data pull.

seraphx2 commented 6 years ago

Are you using the NuGet package? I changed it from decimal to double on GitHub. I believe that should most likely be able to hold the value.

Monkey7539 commented 6 years ago

I was the nuget was set to decimal until little while ago. You may also want to update dogma attribute for type to double as some of them throw decimal error as well.

seraphx2 commented 6 years ago

ok. will do when I get home.

Robert Burke | Gamer / Developer Sent from Outlookhttps://aka.ms/qtex0l on my iPhone


From: Monkey notifications@github.com Sent: Tuesday, July 3, 2018 4:32:51 PM To: seraphx2/ESI.NET Cc: seraphx2; Comment Subject: Re: [seraphx2/ESI.NET] Error being thrown on Type - Mass (#2)

I was the nuget was set to decimal until little while ago. You may also want to update dogma attribute for type to double as some of them throw decimal error as well.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/seraphx2/ESI.NET/issues/2#issuecomment-402283927, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALBrXMMZ8f5_ZHIMx35YMs1Q1_JKsZ8sks5uC9TzgaJpZM4VBXVs.

Monkey7539 commented 6 years ago

np. I ended up cloning and using local copy for the time being. Just figured I'd help with debugging. I know it can be a pain.

seraphx2 commented 6 years ago

unfortunately I can only validly test so many things anyway (especially things to do with alliances) and will have to rely on people to come across issues I can't dream of and report them.

thanks for the help.

Robert Burke | Gamer / Developer Sent from Outlookhttps://aka.ms/qtex0l on my iPhone


From: Monkey notifications@github.com Sent: Tuesday, July 3, 2018 4:34:59 PM To: seraphx2/ESI.NET Cc: seraphx2; Comment Subject: Re: [seraphx2/ESI.NET] Error being thrown on Type - Mass (#2)

np. I ended up cloning and using local copy for the time being. Just figured I'd help with debugging. I know it can be a pain.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/seraphx2/ESI.NET/issues/2#issuecomment-402284467, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALBrXPAJOJVzsdUTysPCAsuGpRiMw9Dvks5uC9VzgaJpZM4VBXVs.

seraphx2 commented 6 years ago

@Monkey7539 Can you be more specific about the dogma one? I'm not following which class/property you mean.

DeathZeppelin commented 6 years ago

I am gonna guess he was refering to the DefaultValue property in the Attribute class. its the only decimal i saw in all of the dogma section.

seraphx2 commented 6 years ago

Fixed. Will be released in the near future.