search

seraphx2 / ESI.NET

A C# wrapper for the Eve Online ESI API.
https://www.nuget.org/packages/ESI.NET/
MIT License
40 stars 23 forks source link

Thread safe #55

Closed DragonSA closed 1 year ago

DragonSA commented 1 year ago

The main focus of this branch is to ensure thread safety of ESI.NET. The use of DefaultHeaders instead of HttpRequestMessage.Headers was causing concurrency issues when the headers were modified simultaneously from different threads.

I also:

seraphx2 commented 1 year ago

Sorry. Getting on this today. Time flies. lol. ended up forgetting this was here. I'll test this and then merge if all goes well. And thanks for the .net updates. I actually had a branch with that same change, so I'll just take yours. :p

Ablecken commented 1 year ago

Hey there, just wondering if you are still working on getting this in? I want to use it but need/want it to be threadsafe. No worries if not, just wanted a timeline on if I should use the fork and build it or wait for a merge and use the nuget package.

seraphx2 commented 1 year ago

blah. forgot to finish this up. let me double check everything and i should have a build out in just a little bit today. sorry about that

seraphx2 commented 1 year ago

All is good to go. After having not deployed for a year, some tokens, auth, and unsupported versions in tasks were all broken or off lol.

Ablecken commented 1 year ago

Awesome, thanks a ton

DragonSA commented 1 year ago

It's a pleasure. Glad to be of help.