search

seratch / AWScala

Using AWS SDK on the Scala REPL
Other
736 stars 227 forks source link

Merge in Kinesis implementation? #172

Open colindean opened 6 years ago

colindean commented 6 years ago

https://github.com/bizreach/aws-kinesis-scala provides "jp.co.bizreach" %% "aws-kinesis-scala" and seems to have a very similar implementation style.

Maybe it could be or serve as the basis of implementing Kinesis support?

seratch commented 6 years ago

It may be fine. What do you think? @takezoe

takezoe commented 6 years ago

aws-kinesis-scala consists the core module and the spark support module. I think the core module can be merged with AWScala basically, but it contains not only Scala wrapper of AWS-SDK but some additional features like automatic retry fashion. I'm not sure these features should be merged.

seratch commented 6 years ago

Thank you for your detailed explanation. I prefer a simple wrapper of Java SDK.

Anyway, if somebody makes a pull request to merge a Kinesis module, I am willing to merge it regardless of whether it's based on aws-kinesis-scala or not.