search

seratch / slack-edge

Slack app development framework for edge functions with streamlined TypeScript support
https://github.com/seratch/slack-edge-app-template
MIT License
87 stars 5 forks source link

Update return type in fromHexStringToBytes for Next.js compatibility #25

Closed abc123931 closed 4 months ago

abc123931 commented 4 months ago

issue #24

Overview

This PR addresses an issue in the fromHexStringToBytes function that was causing errors in Next.js applications. To resolve this, the return type of the function has been changed from ArrayBufferLike to Uint8Array.

Changes

Testing

The function has been tested locally in a Next.js setup and is working as expected. However, tests in environments such as Cloudflare Workers are pending.

Please review the changes and let me know if there are any concerns or additional adjustments needed. Further testing in other environments will be conducted as needed.

seratch commented 4 months ago

Thanks! I don’t remember why the buffer method call is necessary, but we need to do thorough tests before merging this change.

seratch commented 4 months ago

Thanks again for your contribution! Your change was included in v0.10.10, which I just shipped