seraxis / lr2oraja-endlessdream

A featureful fork of beatoraja
https://github.com/seraxis/lr2oraja-endlessdream/releases
GNU General Public License v3.0
46 stars 7 forks source link

Add IntelliJ run configurations for building with Gradle #22

Closed corndogit closed 6 months ago

corndogit commented 6 months ago

This PR removes the catch-all exclusion of the .idea folder while following the gitignore.io template for IntelliJ projects. This allows run configurations to be shared in repo, both for new contributors or for the sake of convenience.

Changes

corndogit commented 6 months ago

Should also mention that this came off the back of looking for a way to include some project structure information in the repo, specifically defining source folders for the submodule dependencies.

In summary it seems like there's no need to include the module dependency stuff in .idea if its already managed by Gradle, if anyone else runs into IDEA having issues about invalid bms.model.* or bms.table.* imports, maybe the step to mark the submodule src folders as sources could be added to the README.

seraxis commented 6 months ago

Excellent PR.

I think the real solution for the missing module dependencies is having a proper build.gradle.kts in each of the submodules so they can be managed dependencies instead of the hacky SourceSet nonsense that merges the namespaces at runtime (critically not visible to IDEs)