Global FREQ+ - Githubissues

seraxis / lr2oraja-endlessdream

A featureful fork of beatoraja

https://github.com/seraxis/lr2oraja-endlessdream/releases

GNU General Public License v3.0

46 stars 7 forks source link

Global FREQ+ #6

Closed hadronyche closed 9 months ago

hadronyche commented 9 months ago

Added a global set-and-forget FREQ+, integrated into the random trainer:

Additional considerations:

Limit the slider to steps?
- Currently, any integer between 100-200
- Sliders can be Ctrl-clicked for manual input
Skinnable FREQ+ %
More testing
- During dev it messed with the practice mode freq, but I think it's isolated now.
Clean up code

hadronyche commented 9 months ago

Doesn't work, chart render and actual chart are disconnected. Will investigate later.

hadronyche commented 9 months ago

It's in a good spot now, worth testing.

seraxis commented 9 months ago

Wow, great work, I'd like to integrate this into a refactor of the ImGui menu into submenus so this will remain open for the time being. Might be best if I opened a tracking PR with these changes integrated into the refactor?

hadronyche commented 9 months ago

Agree, I had the same thought about sub-menus or something like collapsible sections for different features. Would be good to generalise the trainer menu a little.

hadronyche commented 9 months ago

Testing right now, there's an issue where it doesn't apply ran. Probably because I've overwritten whatever PatternMod applied. There's also one chart I've found that fast forwards to 20% through instantly. Working otherwise.

Edit: 8b8008a solves both issues, pending testing. P.S. freq+ on autoplay is disabled. Won't support in the scope of this PR.

seraxis commented 9 months ago

closed, superseded by #9