search

serayuzgur / crates

crates is an extension aims to help people to manage their dependencies for rust (crates.io & TOML).
https://marketplace.visualstudio.com/items?itemName=serayuzgur.crates
MIT License
238 stars 36 forks source link

Pre-release versions show up as an "X" by default #151

Open kotx opened 2 years ago

kotx commented 2 years ago

Describe the bug Pre-release versions will show up as an "X" despite being newer than the latest releases, unless crates.listPreReleases is true. However, this config setting also lists pre-release versions in the version list, which may not be desired.

To Reproduce Steps to reproduce the behavior:

  1. Use a RC or beta version of a crate like rocket 0.5.0-rc.1
  2. See the "X" in Cargo.toml
  3. Set crates.listPreReleases to true
  4. See the absence of the "X"

Expected behavior Pre-release versions should not error even when crates.listPreReleases is set to false.

Screenshots

image image

Desktop (please complete the following information):

msdrigg commented 2 years ago

I would agree especially because the settings flag is global. This makes it difficult to use everywhere because some projects I am using pre-releases but others I dont.

Maybe it would be possible to have pre-releases marked with a yellow warning or something similar when the allow-pre-release setting is turned off. (And a similar warning when not using pre-releases when the setting is turned on).

I know this isn’t exactly what you are asking for, but would this resolve your issue?

kotx commented 2 years ago

That looks good to me!

0PandaDEV commented 3 months ago

Any updates on this, it really annoys me.

serayuzgur commented 3 months ago

we are working on an update, all parsing etc refactored. So please lets deal all with these after the new release. It will be easier to patch things up after refactor.