search

serazing / xscale

Xscale a library of multi-dimensional signal processing tools using parallel computing
Apache License 2.0
25 stars 12 forks source link

Fix window plot #13

Closed apatlpo closed 6 years ago

apatlpo commented 6 years ago

I just realized you had a PR pending about pandas. I'll let you figure out how to best sort out the mess and won't feel bad if you ignore this PR ...

serazing commented 6 years ago

Hi, I just fixed the pandas dtype bug and the setup requirements in PR #12. Can you rebase your branch on master and just submit changes for window plot. A good thing would be to also add test for the plots but this would require much work.

apatlpo commented 6 years ago

I updated the present PR to get rid of conflicts

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.04%) to 53.699% when pulling 2f1efcdd49d8e1efc109825fb3ac10be57d84104 on apatlpo:master into 2de22830690dd8abc6522d6bfa46eb877248d9e1 on serazing:master.

codecov-io commented 6 years ago

Codecov Report

Merging #13 into master will decrease coverage by 0.04%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage   53.23%   53.18%   -0.05%     
==========================================
  Files          11       11              
  Lines        1082     1083       +1     
==========================================
  Hits          576      576              
- Misses        506      507       +1
Impacted Files Coverage Δ
xscale/filtering/linearfilters.py 39.48% <0%> (-0.21%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2de2283...2f1efcd. Read the comment docs.