search

serazing / xscale

Xscale a library of multi-dimensional signal processing tools using parallel computing
Apache License 2.0
25 stars 12 forks source link

python 3 support #6

Closed rabernat closed 6 years ago

rabernat commented 7 years ago

I see you are only testing with python 2...does xscale support python 3? I want to try it, but I need to set up an environment first. I would prefer python 3 if possible.

rabernat commented 7 years ago

update: it definitely does NOT support python 3.5.

serazing commented 7 years ago

Agreed, I will add a support for python 3.5. Xscale tests principally fail with python 3 because of the use of basestring in _utils. I will correct that soon.

serazing commented 7 years ago

Ok, Xscale tests now work with Python 3.5 (see Travis CI). I will keep the discussion opened since the code coverage is only 50% for the moment. Let me know if there are other issues with Python 3.

rabernat commented 7 years ago

Was there a PR to fix this? Or did you just push directly?

serazing commented 7 years ago

I have pushed it directly but I think I should stop doing that, at least for issues in order to track changes. I reckon still lack of experience with github.