search

serbanghita / Mobile-Detect

Mobile_Detect is a lightweight PHP class for detecting mobile devices (including tablets). It uses the User-Agent string combined with specific HTTP headers to detect the mobile environment.
http://mobiledetect.net
MIT License
10.55k stars 2.68k forks source link

Not detect Lenovo tabs #855

Closed wzhik closed 2 years ago

wzhik commented 3 years ago

Issue description Doesn't recognize the device as a tablet

User-Agent(s) Mozilla/5.0 (Linux; arm_64; Android 10; Lenovo TB-X606F) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.141 YaBrowser/20.12.5.121.01 Safari/537.36

Suggestions

serbanghita commented 3 years ago

Thank you! Will be fixed in the next release!

dogslife commented 2 years ago

Have similar issues with 2.8.39 - Whilst Lenovo TB-X505L is listed in tabletDevices array (line 451) but isTablet() returns false. Mozilla Firefox 104.1.0 Android 10

dogslife commented 2 years ago

Are you suggesting that this is resolved in a future/current release or that you are simply not going to support it via your 'depreciated' tag? A little clarity would be appreciated

serbanghita commented 2 years ago

Are you suggesting that this is resolved in a future/current release

@wzhik @dogslife both tablets have been added to Mobile Detect, I must have probably forgot to mention. Thank you for the report! 🙏

@dogslife I decided to clean/close all old issues that had incompatible requests or code changes that didn't have any tests or follow-up because I am releasing in parallel a version for PHP 7.x and then 8.x. I think what I meant with deprecated is that the issue has been stalled by me and I closed it so I can start clean.

I thought that if the OP is interested in pursuing the issue, I will reopen it if I find it applicable to MobileDetect.