search

serbanghita / Mobile-Detect

Mobile_Detect is a lightweight PHP class for detecting mobile devices (including tablets). It uses the User-Agent string combined with specific HTTP headers to detect the mobile environment.
http://mobiledetect.net
MIT License
10.55k stars 2.68k forks source link

Fix the license file so Github can pick it up in the UI #861

Closed exussum12 closed 3 years ago

exussum12 commented 3 years ago

The licence file has both a licence and a contributing agreement.

Would you be open to splitting them into 2 files ?

serbanghita commented 3 years ago

@exussum12 sure! What is your use case for this change?

exussum12 commented 3 years ago

Github doesn't pick up the licence correctly due to the additional non licence text at the bottom. They pick the correct file, but can't work out the licence

serbanghita commented 3 years ago

@exussum12 where did you noticed this? I want to replicate it myself

exussum12 commented 3 years ago

https://github.com/serbanghita/Mobile-Detect/blob/5.x/LICENSE.txt

That should show something like

https://github.com/doctrine/dbal/blob/3.1.x/LICENSE

image

vs

image

If you remove the bottom section yours will also have the correct licence picked up

serbanghita commented 3 years ago

@exussum12 thanks, fixed in https://github.com/serbanghita/Mobile-Detect/commit/10d919b34a0dbd2a72a3c90b09f797edef66988a Screenshot 2021-05-26 at 11 52 38

exussum12 commented 3 years ago

Amazing thank you!