search

serbanghita / Mobile-Detect

Mobile_Detect is a lightweight PHP class for detecting mobile devices (including tablets). It uses the User-Agent string combined with specific HTTP headers to detect the mobile environment.
http://mobiledetect.net
MIT License
10.52k stars 2.67k forks source link

Consider running 7x workflow against all supported PHP versions #914

Closed acelaya closed 10 months ago

acelaya commented 1 year ago

I have noticed the 7x.yml workflow only runs against PHP 7.4. I was thinking if you would be interested in making it run against PHP 8.0, 8.1 and 8.2 as well, to ensure compatibility with all supported versions.

I can provide a PR if so.

serbanghita commented 10 months ago

@acelaya thank you for mentioning this

I have updated the workflows as such

https://github.com/serbanghita/Mobile-Detect/blob/2.8.x/.github/workflows/2.8.x-test.yml php-version: ["5.3"] https://github.com/serbanghita/Mobile-Detect/blob/3.74.x/.github/workflows/3.74.x-test.yml php-version: [7.4] https://github.com/serbanghita/Mobile-Detect/blob/4.8.x/.github/workflows/4.8.x-test.yml php-version: [8.0, 8.1, 8.2]

If you think this is not enough please let me know, thank you!