search

serdarciplak / BlazorMonaco

Blazor component for Microsoft's Monaco Editor which powers Visual Studio Code.
https://serdarciplak.github.io/BlazorMonaco/
MIT License
432 stars 98 forks source link

feat: add dotnet 8 support #113

Closed DanielCordell closed 5 months ago

DanielCordell commented 8 months ago

Closes https://github.com/serdarciplak/BlazorMonaco/issues/114

Added dotnet 8 support for both the BlazorMonaco project & the SampleApp.

Was able to publish & run it locally.

image

Am using the prerelease SDK, should be the same for the release version.

image

Also added in the loading spinner from the default msft blazor template as well.

DanielCordell commented 7 months ago

@MarijnPessers @serdarciplak Is there any chance one of you could review this please (or give an ETA for when you think you could)? It's blocking the migration I'd like to make to one of my projects at work :)

No pressure if right now is not a good time though!

serdarciplak commented 6 months ago

Hi @DanielCordell I'll add net8 support together with a few more changes in the next version soon. But as no code changes are needed for net8 support, you can already use it in net8. Many other libraries also don't have a dll built for net8 but can be used in net8. Why do you need net8 to be declared explicitly?

DanielCordell commented 6 months ago

Hi @DanielCordell I'll add net8 support together with a few more changes in the next version soon. But as no code changes are needed for net8 support, you can already use it in net8. Many other libraries also don't have a dll built for net8 but can be used in net8. Why do you need net8 to be declared explicitly?

I don't! I updated the issue saying that I managed to get it working without, I'd made a mistake in my configuration! https://github.com/serdarciplak/BlazorMonaco/issues/114#issuecomment-1883914587

No rush at all on any of this :)

serdarciplak commented 5 months ago

Added this in #120 with other small fixes. It will be released in BlazorMonaco v3.2.0