search

serde-ml / serde

Serialization framework for OCaml
MIT License
174 stars 11 forks source link

Use of `==` in README code #1

Closed lindig closed 1 year ago

lindig commented 1 year ago

Code in the README uses at various places == which is pointer equality in OCaml and quite likely to be wrong because you are looking for structural equality. Otherwise it would be good to explain why pointer equality is required in these places.

leostera commented 1 year ago

Hi @lindig, good call-out. If you look at the tests they're all using ppx_deriving.eq to make structural equality comparisons. The readme was illustrative. I'll amend it so its not misleading :)

Thanks!