serebrov / emoji-mart-vue

One component to pick them all (performance improvements) 👊🏼
https://serebrov.github.io/emoji-mart-vue/
BSD 3-Clause "New" or "Revised" License
268 stars 48 forks source link

Susnux: feat emoji 15 #273

Closed serebrov closed 1 year ago

serebrov commented 1 year ago

A branch to test, merge, and release the original change from #270.

codecov-commenter commented 1 year ago

Codecov Report

Merging #273 (d0f6868) into master (f552fa1) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #273   +/-   ##
=======================================
  Coverage   89.42%   89.42%           
=======================================
  Files          15       15           
  Lines         577      577           
  Branches      143      143           
=======================================
  Hits          516      516           
  Misses         55       55           
  Partials        6        6           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

serebrov commented 1 year ago

Testing it locally, everything looks good except google emojis: they seem to be shifted.

For example, native smiles:

Screenshot 2023-06-10 at 23 13 27

And google:

Screenshot 2023-06-10 at 23 13 50
susnux commented 1 year ago

Testing it locally, everything looks good except google emojis: they seem to be shifted.

This is known, I have submitted a patch. We need to update to version 15.0.1 :)

serebrov commented 1 year ago

Related: https://github.com/iamcal/emoji-data/pull/228/files and https://github.com/iamcal/emoji-data/pull/226.

We actually already have v 15.0.1 in the package.json, but links in the CSS files pointed to 15.0.0, fixed in 7be8109

serebrov commented 1 year ago

@susnux I published version 15.0.0 with emoji 15 update, thanks for your help!