Make php-cli-snake an optional requirement

seregazhuk / php-watcher

Monitor for any changes in your php application and automatically restart it (suitable for async apps).

https://sergeyzhuk.me/2019/10/18/php-watcher/

389 stars 31 forks source link

Make php-cli-snake an optional requirement #60

Closed mmoreram closed 4 years ago

mmoreram commented 4 years ago

I would only make it a required library if is enabled. Otherwise, disable the loader.

seregazhuk commented 4 years ago

Why? What's wrong with this dependency? 🤔

mmoreram commented 4 years ago

Nothing at all. By adding as a dependency in this project makes all projects using this watcher a strong dependency, even if we don't use the loader. This dep could be defined as an optional requirement :)

seregazhuk commented 4 years ago

But this library has actually zero dependencies :) I think it is OK to keep it 🤷‍♂

mmoreram commented 4 years ago