sereko / theunarchiver

Automatically exported from code.google.com/p/theunarchiver
Other
0 stars 0 forks source link

The Unarchiver doesn't support quarantine propagation #193

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
One of the more important tasks that Bom performs when unarchiving is 
propagating quarantine 
attributes.  The Unarchiver doesn't do this, resulting in security issues.

Original issue reported on code.google.com by drspring...@gmail.com on 3 Sep 2009 at 9:55

GoogleCodeExporter commented 9 years ago
If you have some handy documentation about how exactly it is supposed to work, 
that 
would be helpful.

Original comment by paracel...@gmail.com on 4 Sep 2009 at 12:35

GoogleCodeExporter commented 9 years ago
I think it's done by copying the quarantine attributes 
(kLSItemQuarantineProperties) using LSCopyItemAttribute 
(http://developer.apple.com/mac/library/documentation/Carbon/Reference/LaunchSer
vicesReference/Reference
/reference.html#//apple_ref/c/func/LSCopyItemAttribute), and setting it on all 
unarchives files using LSSetItemAttribute 
(http://developer.apple.com/mac/library/releasenotes/Carbon/RN-
LaunchServices/index.html).  Let me try this out though.

Original comment by drspring...@gmail.com on 4 Sep 2009 at 2:43

GoogleCodeExporter commented 9 years ago
Yep, worked like a charm.  Here's a test program.

Original comment by drspring...@gmail.com on 4 Sep 2009 at 4:41

Attachments:

GoogleCodeExporter commented 9 years ago
It copies quarantine attributes from argv[1] to argv[2], e.g. from foo.zip to 
foo

Original comment by drspring...@gmail.com on 4 Sep 2009 at 4:43

GoogleCodeExporter commented 9 years ago
All right, thanks a lot for that. I'll try to get it working for the next 
version.

Original comment by paracel...@gmail.com on 4 Sep 2009 at 12:18

GoogleCodeExporter commented 9 years ago
Implemented, hopefully correctly.

Original comment by paracel...@gmail.com on 25 Sep 2009 at 3:12